Skip to content

YARN-11257. Add junit5 dependency to hadoop-yarn-server-timeline-pluginstorage to fix few unit test failure#4770

Closed
hotcodemacha wants to merge 1 commit intoapache:trunkfrom
hotcodemacha:YARN-11257
Closed

YARN-11257. Add junit5 dependency to hadoop-yarn-server-timeline-pluginstorage to fix few unit test failure#4770
hotcodemacha wants to merge 1 commit intoapache:trunkfrom
hotcodemacha:YARN-11257

Conversation

@hotcodemacha
Copy link
Contributor

@hotcodemacha hotcodemacha commented Aug 20, 2022

Description of PR

Add junit5 dependency to hadoop-yarn-server-timeline-pluginstorage to some unit test failure

JIRA - YARN-11257

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hotcodemacha hotcodemacha changed the title YARN-11257. Add junit5 dependency to hadoop-yarn-server-timeline-pluginstorage to some unit test failure YARN-11257. Add junit5 dependency to hadoop-yarn-server-timeline-pluginstorage to fix few unit test failure Aug 20, 2022
aajisaka
aajisaka approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending Jenkins. Thanks.

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 20, 2022

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 18s trunk passed
+1 💚 compile 0m 46s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 0m 44s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 mvnsite 0m 50s trunk passed
+1 💚 javadoc 0m 54s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 0m 42s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 62m 12s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 29s the patch passed
+1 💚 compile 0m 29s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javac 0m 29s the patch passed
+1 💚 compile 0m 27s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 27s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 29s the patch passed
+1 💚 javadoc 0m 26s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 0m 25s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 22m 10s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 40s hadoop-yarn-server-timeline-pluginstorage in the patch passed.
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
89m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4770/1/artifact/out/Dockerfile
GITHUB PR #4770
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 4f2f3acdaba9 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 99650a5
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4770/1/testReport/
Max. process+thread count 694 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4770/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hotcodemacha
Copy link
Contributor Author

hotcodemacha commented Aug 20, 2022

Thanks @aajisaka for reviewing. Follow-up PR for upgrading in complete hadoop-yarn-server-timeline-pluginstorage - #4771

aajisaka
aajisaka requested changes Aug 20, 2022
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cancelling my +1. The tests were not actually running. Could you update the tests to use junit 5? Sorry for back and forth.

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4770/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timeline-pluginstorage.

@aajisaka
Copy link
Member

aajisaka commented Aug 20, 2022 •
edited
Loading

You've already created #4771 and I'll look into this.

@hotcodemacha
Copy link
Contributor Author

hotcodemacha commented Aug 20, 2022

You've already created #4771 and I'll look into this.

Thanks

@hotcodemacha
Copy link
Contributor Author

hotcodemacha commented Aug 20, 2022

Cancelling my +1. The tests were not actually running. Could you update the tests to use junit 5? Sorry for back and forth.

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4770/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timeline-pluginstorage.

I cant access this link. Can you share what's the error. In my local - even with this change, tests were passing.

@hotcodemacha
Copy link
Contributor Author

hotcodemacha commented Aug 20, 2022

Closing this PR as we have this follow-up PR #4771

@aajisaka
Copy link
Member

aajisaka commented Aug 20, 2022

Sorry I pasted the wrong link. Can you access to https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4770/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timeline-pluginstorage.txt ?

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

@hotcodemacha
Copy link
Contributor Author

hotcodemacha commented Aug 20, 2022

Yes. Now I can access. Thanks for sharing.

@susheel-gupta susheel-gupta mentioned this pull request Nov 29, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aajisaka aajisaka aajisaka requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hotcodemacha @hadoop-yetus @aajisaka